[VOTE] Apache POI 3.15 RC3

Discussion:

David North

2016-09-17 17:07:42 UTC

Hi everyone,

https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/

Areas to review:

* Does it work?
* Are the sigs and hashes valid?
* Have the issues with the last RC been fixed?
* Are the release notes (inc requested additions from Javen) OK?

The vote starts now and ends at 18:15 BST on Monday, 21 September.

Here is my +1.

Thanks,

--
David North | www.dnorth.net

Javen O'Neal

2016-09-17 17:30:33 UTC

Permalink

Is this memory savings seen during regular use of POI, such as the
following example, or only when explicitly created with user code calling
lower level OPCPackage operations? If so, should release notes mention the
lower memory usage for OOXML documents due to File Backed Data Source?

Workbook wb = WorkbookFactory.open(file);
// Do some things to workbook
OutputStrem out = new FileOutputStream(outfile);
wb.write(out):
wb.close();
out.close();

Post by David North
Hi everyone,
https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/
* Does it work?
* Are the sigs and hashes valid?
* Have the issues with the last RC been fixed?
* Are the release notes (inc requested additions from Javen) OK?
The vote starts now and ends at 18:15 BST on Monday, 21 September.
Here is my +1.
Thanks,
--
David North | www.dnorth.net

Dominik Stadler

2016-09-18 16:54:08 UTC

Permalink

Hi,

As far as I see it only reduces the amount of memory held while the file
was open, closing correctly already freed up the memory in previous
versions as well. It also only was visible with read-only access as then we
do not use memory-mapping. The user seems to have a very large file at some
point which consumes lots of memory during reading the content and thus the
memory usage spiked considerably here.

I think we introduced File Backed Data Source in the mainstream via the
switch to NPOIFS and the actual memory usage later on with a fix for an
actual memory leak in NIO Java classes where we needed to put in a
workaround to release memory.

Not sure if it is worthwhile to mention in the release notes as we did not
do any measurements of actual effect.

Dominik.

Post by Javen O'Neal
Is this memory savings seen during regular use of POI, such as the
following example, or only when explicitly created with user code calling
lower level OPCPackage operations? If so, should release notes mention the
lower memory usage for OOXML documents due to File Backed Data Source?
Workbook wb = WorkbookFactory.open(file);
// Do some things to workbook
OutputStrem out = new FileOutputStream(outfile);
wb.close();
out.close();

Javen O'Neal

2016-09-18 21:07:29 UTC

Permalink

When I got OOM's with POI because of insufficient heap size, I would
get them when I called wb.write(FileOutputStream).
IIRC I was using POI 3.8 and 3.9 when doing this memory testing.

Post by Dominik Stadler
Hi,
As far as I see it only reduces the amount of memory held while the file
was open, closing correctly already freed up the memory in previous
versions as well. It also only was visible with read-only access as then we
do not use memory-mapping. The user seems to have a very large file at some
point which consumes lots of memory during reading the content and thus the
memory usage spiked considerably here.
I think we introduced File Backed Data Source in the mainstream via the
switch to NPOIFS and the actual memory usage later on with a fix for an
actual memory leak in NIO Java classes where we needed to put in a
workaround to release memory.
Not sure if it is worthwhile to mention in the release notes as we did not
do any measurements of actual effect.
Dominik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@poi.apache.org
For additional commands, e-mail: dev-***@poi.apache.org

Dominik Stadler

2016-09-18 18:09:34 UTC

Permalink

I did my usual tests of comparing release-content and running the newer
jars with my local projects, this time all worked fine for me, so I am
finally

+1

Thanks... Dominik.

Andreas Beeker

2016-09-18 19:50:31 UTC

Permalink

+1

Sigs and docs look ok.
As this is a final release, please also add a note pointing to #59170 in the release notes.
FYI, I've removed the obsolete nexus repos.

Andi

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@poi.apache.org
For additional commands, e-mail: dev-***@poi.apache.org

Allison, Timothy B.

2016-09-19 14:50:11 UTC

Permalink

+1

Built on Windows and integrated successfully with Tika and Tika's unit tests. I'm relying on my earlier run of RC2 on the full regression corpus as evidence that we're in good shape.

Thank you, David!

Cheers,

Tim

-----Original Message-----
From: David North [mailto:***@apache.org]
Sent: Saturday, September 17, 2016 1:08 PM
To: POI Developers List <***@poi.apache.org>
Subject: [VOTE] Apache POI 3.15 RC3

Hi everyone,

https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/

Areas to review:

* Does it work?
* Are the sigs and hashes valid?
* Have the issues with the last RC been fixed?
* Are the release notes (inc requested additions from Javen) OK?

The vote starts now and ends at 18:15 BST on Monday, 21 September.

Here is my +1.

Thanks,

--
David North | www.dnorth.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@poi.apache.org
For additional commands, e-mail:

Javen O'Neal

2016-09-20 01:47:23 UTC

Permalink

+1 from me.

Initiate countdown sequence. 10... 9... 8...

Post by Allison, Timothy B.
+1
Built on Windows and integrated successfully with Tika and Tika's unit
tests. I'm relying on my earlier run of RC2 on the full regression corpus
as evidence that we're in good shape.
Thank you, David!
Cheers,
Tim
-----Original Message-----
Sent: Saturday, September 17, 2016 1:08 PM
Subject: [VOTE] Apache POI 3.15 RC3
Hi everyone,
https://dist.apache.org/repos/dist/dev/poi/3.15-RC3/
* Does it work?
* Are the sigs and hashes valid?
* Have the issues with the last RC been fixed?
* Are the release notes (inc requested additions from Javen) OK?
The vote starts now and ends at 18:15 BST on Monday, 21 September.
Here is my +1.
Thanks,
--
David North | www.dnorth.net
---------------------------------------------------------------------

David North

2016-09-20 12:24:31 UTC

Permalink

Thanks all. I'll do the tally and final actions tonight with a bit of luck.

Post by Javen O'Neal
+1 from me.
Initiate countdown sequence. 10... 9... 8...

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@poi.apache.org
For additional commands, e-mail: dev-***@poi.apache.org

David North

2016-09-21 06:21:57 UTC

Permalink

+1 = 5

No 0, no -1

Accordingly, I will now release 3.15. Thanks everyone.

Post by David North
Thanks all. I'll do the tally and final actions tonight with a bit of luck.

Post by Javen O'Neal
+1 from me.
Initiate countdown sequence. 10... 9... 8...

---------------------------------------------------------------------

--
David North | www.dnorth.net

David North

2016-09-21 06:31:07 UTC

Permalink

Just waiting for it to roll out to the mirrors, then I'll send the
announce and sort the website.

Nick - please can you sort the Bugzilla versions?

Thanks,
David

Post by David North
+1 = 5
No 0, no -1
Accordingly, I will now release 3.15. Thanks everyone.

Post by David North
Thanks all. I'll do the tally and final actions tonight with a bit of luck.

Post by Javen O'Neal
+1 from me.
Initiate countdown sequence. 10... 9... 8...

---------------------------------------------------------------------

--
David North | www.dnorth.net

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@poi.apache.org
For additional commands, e-mail: dev-***@poi.apache.org

Nick Burch

2016-09-21 09:37:38 UTC

Permalink

Post by David North
Nick - please can you sort the Bugzilla versions?

Added 3.15-FINAL and 3.16-dev

3.14-dev and 3.11-FINAL disabled for new bugs

Nick

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-***@poi.apache.org
For additional commands, e-mail: dev-***@poi.apache.org